Enhance cleanup function #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprodanov4
approved these changes
Jan 20, 2026
atanasdinov
approved these changes
Jan 20, 2026
ipetrov117
added a commit
to ipetrov117/upgrade-controller
that referenced
this pull request
Jan 20, 2026
(cherry picked from commit a82c73b) Signed-off-by: Ivo Petrov <ivo.petrov@suse.com>
ipetrov117
added a commit
that referenced
this pull request
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases where the pod running the
os-upgrade.shscript can be abruptly stopped (e.g. due to an update of SUC where at the same time OS migration is running).In such cases, the previous cleanup logic left the state of the
os-migration.servicein a very dirty state, where consecutive pods running theos-upgrade.shscript were unable to start theos-migration.serviceagain and immediately errored out with the following error:The suggested changes enhance the cleanup function to: